[Asterisk-code-review] chan_sip.c Session timers get removed on UPDATE (asterisk[16])

[N A]

Attention is currently required from: Joshua Colp, Mark Petersen.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17787 )

Change subject: chan_sip.c Session timers get removed on UPDATE
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17787/comment/1de633a7_87703a2e 
PS1, Line 9: asteriks 
asteriks should be spelled "Asterisk". Ditto for the usage on the first line.


https://gerrit.asterisk.org/c/asterisk/+/17787/comment/6ff4c39e_9d209ffa 
PS1, Line 9: fix that if asterisk recive an SIP refer with Session-Timers UAC that asteriks maintain Session-Timers when sending UPDATE
recive should be spelled "receives"

I might rephrase the whole thing for clarity as "If Asterisk receives a SIP REFER with Session-Timers UAC, maintain Session-Timers when sending UPDATE".

This makes it a little bit clearer what the problem was and how this is fixing it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17787
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8e9a21c13bf757fa34d778f49ba3cf859b29ae5c
Gerrit-Change-Number: 17787
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Fri, 28 Jan 2022 21:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220128/575e75af/attachment.html>