[Asterisk-code-review] build: Add "basebranch" to .gitreview (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17945 )

Change subject: build: Add "basebranch" to .gitreview
......................................................................


Patch Set 2:

(2 comments)

File build_tools/make_version:

https://gerrit.asterisk.org/c/asterisk/+/17945/comment/79cec8ff_6b1e3393 
PS1, Line 103:         MAINLINE_BRANCH=$(git config -f .gitreview --get gerrit.basebranch)
             :         if [ "x${MAINLINE_BRANCH}" == "x" ] ; then
             : 	        MAINLINE_BRANCH=$(git config -f .gitreview --get gerrit.defaultbranch)
             : 	    fi
> The lines you added also appear to be using mixed tabs and spaces whereas the rest of the file looks to be using spaces as leading whitespace?


https://gerrit.asterisk.org/c/asterisk/+/17945/comment/e89b32f0_e610e801 
PS1, Line 107:         
> you've got red on you



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2941a3b21e668febeb6cfbc1a7bb51a67726fcc4
Gerrit-Change-Number: 17945
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 26 Jan 2022 16:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220126/c9b70f3c/attachment.html>