[Asterisk-code-review] pbx: Ensure we don't operate on dialplan while dialplan is reloading, ... (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright, Joshua Colp.
Hello Sean Bright, Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/17798

to look at the new patch set (#5).

Change subject: pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks
......................................................................

pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks

Previously it was possible to execute 'dialplan add' during a dialplan
reload, causing deadlocks

Now we prevent 'dialplan add' until the dialplan completes reloading
(and all other modules complete reloading).  Any 'dialplan add'
executed during a reload will fail gracefully.

This change also prevents 'continuous dialplan reload'.  Previously
subsequent 'dialplan reload' would all be queued.  For example 10x
'dialplan reload' will result in asterisk being busy reloading
dialplan 10 times in a row, which is not likely desired behavior on
any system when there's backend scripts instructing Asterisk to reload
upon change.

Now, subsequent 'dialplan reload' will result in the normal 'module
reload in progress' type of behavior that many other modules implement
if they recieve commands during a reload.

ASTERISK-29774 #close
Reported-by: Steve Sether

Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
---
M main/pbx.c
M pbx/pbx_config.c
2 files changed, 54 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/98/17798/5
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
Gerrit-Change-Number: 17798
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/d0acff0d/attachment.html>