[Asterisk-code-review] Asterisk Certified 18.9 Preparation (asterisk[certified/18.9])
Joshua Colp
asteriskteam at digium.com
Mon Jan 17 12:40:32 CST 2022
Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17869 )
Change subject: Asterisk Certified 18.9 Preparation
......................................................................
Patch Set 2: Code-Review-1
(8 comments)
File agi/eagi-test.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/26323349_64a4ec61
PS2, Line 9: <defaultenabled>no</defaultenabled>
Where did the indentation go? Sadness.
File apps/app_adsiprog.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/9afc64d2_584fc219
PS2, Line 39: <defaultenabled>no</defaultenabled>
Redness
File apps/app_audiosocket.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/a86147a5_49c57d79
PS2, Line 30: <defaultenabled>no</defaultenabled>
Indentation
File channels/chan_mgcp.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/cf931da3_4e45531c
PS2, Line 37: <use type="module">res_pktccops</use>
Indentation
File res/res_ael_share.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/e8fba49f_e2c5ee2e
PS2, Line 29: <defaultenabled>no</defaultenabled>
Indentation
File utils/extconf.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/45720a02_f28998ae
PS2, Line 43: <defaultenabled>no</defaultenabled>
Indentation
File utils/smsq.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/2af49d95_f0bdb153
PS2, Line 21: <defaultenabled>no</defaultenabled>
Indentation
File utils/stereorize.c:
https://gerrit.asterisk.org/c/asterisk/+/17869/comment/1ca093b9_9455350d
PS2, Line 14: <defaultenabled>no</defaultenabled>
Indentation
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17869
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: certified/18.9
Gerrit-Change-Id: Id12804325c31b1112b6c559fa97c8a6401c051b3
Gerrit-Change-Number: 17869
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 17 Jan 2022 18:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/2878f9c4/attachment.html>
More information about the asterisk-code-review
mailing list