[Asterisk-code-review] res_pjsip_outbound_registration: Show time until expiration (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17789 )

Change subject: res_pjsip_outbound_registration: Show time until expiration
......................................................................


Patch Set 2:

(1 comment)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/17789/comment/e12ee65d_a2329573 
PS1, Line 2291: 		state ? " (exp. " : "", state->client_state->registration_expires - ((int) time(NULL)), state ? "s)" : "");
> Actually, this can end up becoming negative if the remote side isn't responding which can be confusi […]
I think the seconds should be shown either way, as I just ran the command and realized one of my registrations lapsed an hour ago and hadn't registered since.

Now it uses absolute value and adds 'ago' if it already expired, to make it clearer.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17789
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fea15a1a1056c424416def49d1ca8e776c0483
Gerrit-Change-Number: 17789
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 12 Jan 2022 23:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220112/a065b140/attachment.html>