[Asterisk-code-review] chan_pjsip.c, chan_sip.c: do not change 180 to 183 (asterisk[16])

Mark Petersen asteriskteam at digium.com
Wed Jan 12 08:35:46 CST 2022


Attention is currently required from: Joshua Colp, N A.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c, chan_sip.c: do not change 180 to 183
......................................................................


Patch Set 5:

(1 comment)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/8ca70a0e_63590714 
PS5, Line 1625: 				response_code = 183;
> Any harm in making this an option, perhaps?
my problem is that asterisk is not behaving transparent 
asterisk PBX will not indicate ringing if the asterisk GW in front are changing 180 to 183



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 12 Jan 2022 14:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220112/b838f3cc/attachment.html>


More information about the asterisk-code-review mailing list