[Asterisk-code-review] chan_sip.c Fix pickup on channel that are in AST_STATE_DOWN (asterisk[16])

[Joshua Colp]

Attention is currently required from: Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17782 )

Change subject: chan_sip.c Fix pickup on channel that are in AST_STATE_DOWN
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/5e98c52a_82ce29a1 
PS4, Line 9: Resolve issue with pickup on device that uses "183 Progress" and not "180 Ringing"
This line is too long


File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/827c5145_bb4de14b 
PS4, Line 26612: 				* instead. Issue 14005. (Some ISDN switches as well for that
What is Issue 14005 referencing? And it should be stated that app_pickup also does the same.


File doc/CHANGES-staging/chan_sip_pickup_AST_STATE_DOWN.txt:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/6b8d7f92_35f2c31a 
PS4, Line 3: Fix pickup on channel that are in AST_STATE_DOWN
This is an implementation detail which isn't really for users and can be removed



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17782
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4c7d223870f8ce9a7354e0f73d4e4cb2e8b58841
Gerrit-Change-Number: 17782
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Wed, 12 Jan 2022 14:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220112/0f17a26c/attachment.html>