[Asterisk-code-review] res_pjsip: Add utils for checking media types (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17796 )

Change subject: res_pjsip: Add utils for checking media types
......................................................................


Patch Set 3:

(1 comment)

File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17796/comment/d840423c_0913f143 
PS2, Line 4935: 	    rc = pjsip_media_type_cmp(a, b, 0) ? 0 : -1;
> The doxygen says this will return 1, not -1.

That's odd.  I copied the code from ast_sip_is_content_type().  I wonder why that returns -1 for a "true".  Actually, no I don't. 😊



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17796
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ief77675235bd3bf00a6b095d4673fd878d0801b9
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 11 Jan 2022 13:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220111/2c915c7a/attachment.html>