[Asterisk-code-review] res_pjsip: Add utils for checking media types (asterisk[16])

Sean Bright asteriskteam at digium.com
Mon Jan 10 10:00:31 CST 2022


Attention is currently required from: George Joseph.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17796 )

Change subject: res_pjsip: Add utils for checking media types
......................................................................


Patch Set 1:

(1 comment)

File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/17796/comment/0c8bb704_cabaebc6 
PS1, Line 908:  * \param types count of media types to search
> Might be less fragile to pass NULL as the last argument (or another sentinel) to signal that the lis […]
And also annotate the declaration with the sentinel attribute:

 attribute_sentinel

(defined in include/asterisk/compiler.h)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17796
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ief77675235bd3bf00a6b095d4673fd878d0801b9
Gerrit-Change-Number: 17796
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 10 Jan 2022 16:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220110/221ad55a/attachment.html>


More information about the asterisk-code-review mailing list