[Asterisk-code-review] build_tools/make_version: Fix sed(1) syntax compatibility with NetBSD (asterisk[master])

Sean Bright asteriskteam at digium.com
Sun Jan 9 11:52:20 CST 2022


Attention is currently required from: Michał Górny, Jaco Kroon.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17704 )

Change subject: build_tools/make_version: Fix sed(1) syntax compatibility with NetBSD
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17704/comment/5f64864d_0ba8cfc0 
PS3, Line 9: Fix the sed(1) invocation used to process git-svn-id not to use "\s" that is a GNU-ism and is not
           : supported by NetBSD sed.  As a result, this call did not work properly and make_version did output
           : the full git-svn-id line rather than the revision.
Please wrap at 72 columns



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17704
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4b406e2748920643446851a0a252a4ca7245772
Gerrit-Change-Number: 17704
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Michał Górny <mgorny at NetBSD.org>
Gerrit-Attention: Michał Górny <mgorny at NetBSD.org>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Sun, 09 Jan 2022 17:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220109/6b83e8d6/attachment-0001.html>


More information about the asterisk-code-review mailing list