[Asterisk-code-review] Fix sed(1) syntax compatibility with NetBSD (asterisk[master])

Michał Górny asteriskteam at digium.com
Sun Jan 9 02:04:17 CST 2022


Attention is currently required from: Sean Bright, Jaco Kroon.
Michał Górny has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17704 )

Change subject: Fix sed(1) syntax compatibility with NetBSD
......................................................................


Patch Set 2:

(1 comment)

File build_tools/make_version:

https://gerrit.asterisk.org/c/asterisk/+/17704/comment/4cb866ad_ecb0e207 
PS1, Line 101:     SVN_REV=`${GIT} log --pretty=full -1 | ${GREP} -F "git-svn-id:" | sed -e "s/.*\@\([^[:space:]]*\)[[:space:]].*/\1/g"`
> Or just (since we know it's a space-space): […]
Thanks.  I presumed you didn't mean me to replace $(GIT) though ;-).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17704
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie4b406e2748920643446851a0a252a4ca7245772
Gerrit-Change-Number: 17704
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Michał Górny <mgorny at NetBSD.org>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Sun, 09 Jan 2022 08:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220109/8d83358e/attachment.html>


More information about the asterisk-code-review mailing list