[Asterisk-code-review] chan_pjsip.c, chan_sip.c: do not change 180 to 183 (asterisk[16])

[Alexei Gradinari]

Attention is currently required from: N A, Mark Petersen.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c, chan_sip.c: do not change 180 to 183
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS4: 
> it just happens that the section that changes the reply to 183 is the where inband ringing is being  […]
OK.
I tested this patch.
When asterisk receives 180 without SDP from callee and if SDP negotiation has completed the asterisk replies 180 with SDP to caller and the asterisk generates inband ringing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Fri, 07 Jan 2022 18:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220107/7470580c/attachment.html>