[Asterisk-code-review] res_pbx_validate: Add CLI commands to warn of dialplan problems (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17719 )

Change subject: res_pbx_validate: Add CLI commands to warn of dialplan problems
......................................................................


Patch Set 7:

(1 comment)

Patchset:

PS7: 
Not sure if this is relevant, and I haven't encountered this, but would it be preferred to use the same approach as taken here? https://github.com/asterisk/asterisk/blob/a85f2bf34d22f626a723fb233285e7dccce653ba/res/res_pjsip_outbound_registration.c#L2300

That is, callbacks to public APIs should themselves be encapsulated in a local function which is the callback provided to ast_application_register... etc?

If it makes any difference, such callbacks are in the PBX core, and the change here is referring to APIs in other modules. So it seems to me that it should be fine, since the PBX core should always be loaded before modules are, in which case that would not apply here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17719
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7a2c8a6982ee5adaae7f7aa63e311d0e9106e3
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 02:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220106/22f8c1ff/attachment.html>