[Asterisk-code-review] chan_pjsip.c: Do not change 180 Ringing to 183 Progress even if early... (asterisk[16])

Mark Petersen asteriskteam at digium.com
Thu Jan 6 13:36:41 CST 2022


Mark Petersen has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )


Change subject: chan_pjsip.c: Do not change 180 Ringing to 183 Progress even if early_media already enabled
......................................................................

chan_pjsip.c: Do not change 180 Ringing to 183 Progress even if early_media already enabled

fix that reciving a 180 Ringing is not changed to 180 Progress
on channele where early meadia have previus been setup

ASTERISK-29842

Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
---
M channels/chan_pjsip.c
A doc/CHANGES-staging/chan_pjsip_180_sdp.txt
2 files changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/85/17785/1

diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index e8fbb3d..882db3c 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1638,11 +1638,9 @@
 			if (channel->session->endpoint->inband_progress ||
 				(channel->session->inv_session && channel->session->inv_session->neg &&
 				pjmedia_sdp_neg_get_state(channel->session->inv_session->neg) == PJMEDIA_SDP_NEG_STATE_DONE)) {
-				response_code = 183;
 				res = -1;
-			} else {
-				response_code = 180;
 			}
+			response_code = 180;
 		} else {
 			res = -1;
 		}
diff --git a/doc/CHANGES-staging/chan_pjsip_180_sdp.txt b/doc/CHANGES-staging/chan_pjsip_180_sdp.txt
new file mode 100644
index 0000000..56f92e9
--- /dev/null
+++ b/doc/CHANGES-staging/chan_pjsip_180_sdp.txt
@@ -0,0 +1,3 @@
+Subject: chan_pjsip
+
+Do not change 180 Ringing to 183 Progress even if early_media already enabled

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220106/184caad9/attachment-0001.html>


More information about the asterisk-code-review mailing list