[Asterisk-code-review] chan_sip.c: Enable pickup on channel after having received 183 Progress (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17782 )

Change subject: chan_sip.c: Enable pickup on channel after having received 183 Progress
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> As well, I would not accept this against chan_sip as I would consider this a new feature/improvement […]
yes adding support for AST_STATE_PROGRESS / AST_STATE_QUEUED would be a new feature
and should be the fix for chan_pjsip
so my only hope until I have move all customers to 18/20 and then to pjsip
is that this can be classified as a bug for chan_sip (current form) as it is not uncommon that providers send 183 instead of 180, even Asterisk has a Progress funktion :-/
here in Denmark one provider always uses 183 to play there own custom ringtone
and the largest also use 183 if mobile phone is on 2g/3g :-(



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17782
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4c7d223870f8ce9a7354e0f73d4e4cb2e8b58841
Gerrit-Change-Number: 17782
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 15:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220105/50e3fcee/attachment.html>