[Asterisk-code-review] cdr: allow disabling CDR by default on new channels (asterisk[master])

N A asteriskteam at digium.com
Wed Jan 5 07:44:54 CST 2022


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17701 )

Change subject: cdr: allow disabling CDR by default on new channels
......................................................................


Patch Set 7:

(2 comments)

File doc/CHANGES-staging/cdr_disable.txt:

https://gerrit.asterisk.org/c/asterisk/+/17701/comment/dac86d8f_93e9d491 
PS6, Line 5: newly created channels. The default behavior remains
> Explicitly state what the default behavior is.
Done


File include/asterisk/cdr.h:

https://gerrit.asterisk.org/c/asterisk/+/17701/comment/07631be8_795d6174 
PS6, Line 227: 	CDR_DEFAULT_ENABLED = 1 << 7,       /*!< Whether CDR is enabled for each channel by default */
> This should be changed as well to match the option
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibb78c11974bda229bbb7004b64761980e0b2c6d1
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 13:44:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220105/b3d45c3c/attachment-0001.html>


More information about the asterisk-code-review mailing list