[Asterisk-code-review] cdr: allow disabling CDR by default on new channels (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Jan 5 06:51:01 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17701 )

Change subject: cdr: allow disabling CDR by default on new channels
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

File doc/CHANGES-staging/cdr_disable.txt:

https://gerrit.asterisk.org/c/asterisk/+/17701/comment/8d99bfde_acdbad37 
PS6, Line 5: newly created channels. The default behavior remains
Explicitly state what the default behavior is.


File include/asterisk/cdr.h:

https://gerrit.asterisk.org/c/asterisk/+/17701/comment/1c380b69_23980f79 
PS6, Line 227: 	CDR_DEFAULT_ENABLED = 1 << 7,       /*!< Whether CDR is enabled for each channel by default */
This should be changed as well to match the option



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibb78c11974bda229bbb7004b64761980e0b2c6d1
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 12:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220105/ef41a7e0/attachment.html>


More information about the asterisk-code-review mailing list