[Asterisk-code-review] chan_sip.c: Enable pickup on channel after having received 183 Progress (asterisk[16])

[Joshua Colp]

Attention is currently required from: Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17782 )

Change subject: chan_sip.c: Enable pickup on channel after having received 183 Progress
......................................................................


Patch Set 2:

(1 comment)

File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/bd7beea1_64920785 
PS1, Line 24221: 				ast_setstate(p->owner, AST_STATE_RINGING);
> if you look at the "case 182" it is doing the same thing […]
I was referring to other usage of a 183 changing the channel state to ringing. The fact that a 182 does it doesn't apply here, or mean that a 183 should. A 183 response is different and ultimately may or may not mean ringing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17782
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4c7d223870f8ce9a7354e0f73d4e4cb2e8b58841
Gerrit-Change-Number: 17782
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 04 Jan 2022 14:39:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/ca9af3c3/attachment.html>