[Asterisk-code-review] cdr: allow disabling CDR by default on new channels (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jan 4 05:53:17 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17701 )

Change subject: cdr: allow disabling CDR by default on new channels
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

File configs/samples/cdr.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17701/comment/d4133805_986d44de 
PS5, Line 19: ;defaultenabled=yes
I think this option should include "channels" in it, so it is more clear what it refers to. As it is at a glance a user could get confused between "enable" and "defaultenabled".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibb78c11974bda229bbb7004b64761980e0b2c6d1
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 11:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/0072c86e/attachment-0001.html>


More information about the asterisk-code-review mailing list