[Asterisk-code-review] cli: Add command to evaluate dialplan functions (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jan 4 05:43:01 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17714 )

Change subject: cli: Add command to evaluate dialplan functions
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

Patchset:

PS3: 
This should also have a CHANGES entry.


File main/pbx_variables.c:

https://gerrit.asterisk.org/c/asterisk/+/17714/comment/acd7a6f6_7fd558ea 
PS3, Line 937: 			"Usage: dialplan eval function <function>\n"
What does function mean? Is it just the name of the function? Is it the arguments as well?


https://gerrit.asterisk.org/c/asterisk/+/17714/comment/c08dbf06_0f3c2231 
PS3, Line 938: 			"       Evaluate a dialplan function\n";
This should state the limitations as well, such as in regards to dialplan variables.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17714
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I833e97ea54c49336aca145330a2adeebfad05209
Gerrit-Change-Number: 17714
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 11:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/ccd4dc34/attachment.html>


More information about the asterisk-code-review mailing list