[Asterisk-code-review] pbx: Add CLI commands to warn of bad branches or audio playback (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jan 4 05:34:46 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17719 )

Change subject: pbx: Add CLI commands to warn of bad branches or audio playback
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
I'm not -1ing this at this time, but I am not a fan of embedding application specific knowledge and understanding in regards to parsing and behavior in the PBX core for this.

It feels like this should be a larger discussion on the -dev list about how we would actually like such behavior to work in the grand scheme of things, and how it would be implemented such as allowing dialplan modules to provide a mechanism to do verification.

As it is this is a bruteforce approach that could break or become incomplete in the future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17719
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7a2c8a6982ee5adaae7f7aa63e311d0e9106e3
Gerrit-Change-Number: 17719
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 11:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/42cf3b3d/attachment.html>


More information about the asterisk-code-review mailing list