[Asterisk-code-review] tcptls.c: refactor client connection to be more robust (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Sean Bright.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17720 )

Change subject: tcptls.c: refactor client connection to be more robust
......................................................................


Patch Set 2:

(5 comments)

File include/asterisk/tcptls.h:

https://gerrit.asterisk.org/c/asterisk/+/17720/comment/18c4367b_a9e446d0 
PS2, Line 167:   * \brief Attempt to connect, and start a tcptls session within the given timeout
> I don't think the comma is needed
Done


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/bdc4c912_fdde9c1d 
PS2, Line 169:   * Note, on error the tcptls_session's ref count is decremented,* fd and file
> Use \note here? You also have an errant * after 'decremented. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/9a948ed4_c4277618 
PS2, Line 181:   * \brief Attempt to connect, and start a tcptls session
> I don't think the comma is needed
Done


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/67f61c07_875f497a 
PS2, Line 185:   * Note, on error the tcptls_session's ref count is decremented,* fd and file
> Use \note here? You also have an errant * after 'decremented. […]
Done


File main/tcptls.c:

https://gerrit.asterisk.org/c/asterisk/+/17720/comment/8795bfdc_c4308982 
PS2, Line 663: 	ast_fd_clear_flags(desc->accept_fd, O_NONBLOCK);
> I didn't read the commit message - disregard.
Some more info if interested:

I initially had removed this line thinking to leave the socket non blocking. However that caused read problems due to the way iostreams are implemented. To alleviate that problem I had also set the iostream exclusive input flag to true, but then that caused the chan_sip test to fail. At that point figured it was better to leave well enough alone and only do non blocking on connect.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17720
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I907571843a83e43c0742b95a64785f4411f02671
Gerrit-Change-Number: 17720
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 03 Jan 2022 19:31:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220103/2f941c7b/attachment.html>