[Asterisk-code-review] ami: Add AMI event for Wink (asterisk[master])

N A asteriskteam at digium.com
Mon Jan 3 11:36:50 CST 2022


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17780 )

Change subject: ami: Add AMI event for Wink
......................................................................


Patch Set 2:

(3 comments)

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/17780/comment/f7433ab7_f173f041 
PS1, Line 3410:         ast_channel_publish_blob(chan, ast_channel_wink_type(), NULL);
> Leading whitespace is not correct. Should be 1 tab here.
Whoops... this is what I get for copying and pasting in the terminal 😜


https://gerrit.asterisk.org/c/asterisk/+/17780/comment/5accfa47_8f3ae985 
PS1, Line 3882:                                 send_wink_event(chan);
> Leading whitespace is wrong.
Done


https://gerrit.asterisk.org/c/asterisk/+/17780/comment/3f81fb14_1756fc5c 
PS1, Line 3883:                         }
> Leading whitespace is wrong. You didn't do it here but you can fix it.
Nope, that was my fault too... copy and paste quirk again...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17780
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I83e426de5e37baed79a4dbcc91e9e8d030ef1b56
Gerrit-Change-Number: 17780
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 03 Jan 2022 17:36:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220103/0bce2ed4/attachment.html>


More information about the asterisk-code-review mailing list