[Asterisk-code-review] ami: Add AMI event for Wink (asterisk[master])
Sean Bright
asteriskteam at digium.com
Mon Jan 3 11:32:22 CST 2022
Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17780 )
Change subject: ami: Add AMI event for Wink
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
File main/channel.c:
https://gerrit.asterisk.org/c/asterisk/+/17780/comment/da344547_07645459
PS1, Line 3410: ast_channel_publish_blob(chan, ast_channel_wink_type(), NULL);
Leading whitespace is not correct. Should be 1 tab here.
https://gerrit.asterisk.org/c/asterisk/+/17780/comment/c86d1fdc_108c4c38
PS1, Line 3882: send_wink_event(chan);
Leading whitespace is wrong.
https://gerrit.asterisk.org/c/asterisk/+/17780/comment/6c7ecff4_df23b0d2
PS1, Line 3883: }
Leading whitespace is wrong. You didn't do it here but you can fix it.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17780
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I83e426de5e37baed79a4dbcc91e9e8d030ef1b56
Gerrit-Change-Number: 17780
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 03 Jan 2022 17:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220103/7ee8208c/attachment.html>
More information about the asterisk-code-review
mailing list