[Asterisk-code-review] func_frameintercept: Add FRAME_INTERCEPT function (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17716 )

Change subject: func_frameintercept: Add FRAME_INTERCEPT function
......................................................................


Patch Set 3: Code-Review-1

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/4da678cc_f7cbcd1a 
PS3, Line 7: func_frameintercept: Add FRAME_INTERCEPT function
This is not descriptive enough. What does intercept mean? What does it do? Why does this exist alongside func_framedrop?


File configs/samples/stasis.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/d7ae97d0_52b1cd76 
PS3, Line 57: ; decline=ast_channel_wink_type
This should be in a separate change.


File doc/CHANGES-staging/func_frameintercept.txt:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/6423f1e1_e6ff7a33 
PS3, Line 3: Adds the FRAME_INTERCEPT function, which can be used
Same as commit message, this needs to be more descriptive.


File funcs/func_frameintercept.c:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/876a4282_89d00976 
PS3, Line 32: /*! \todo deprecate/remove func_holdintercept in 21, since this module is a superset of its functionality */
The func_holdintercept is currently core supported, unless Sangoma takes this on as core supported then both would continue to exist.


File include/asterisk/stasis_channels.h:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/80a5b9b0_5057aeda 
PS3, Line 536: struct stasis_message_type *ast_channel_wink_type(void);
This should be a separate change.


File main/manager_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/17716/comment/f2d05075_c0197728 
PS3, Line 989: static void channel_wink_cb(void *data, struct stasis_subscription *sub,
This should be a separate change.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17716
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5ad83b95a4dce3b64b408a1497b0cd63051eb274
Gerrit-Change-Number: 17716
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 03 Jan 2022 16:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220103/550fdceb/attachment.html>