[Asterisk-code-review] cli: Fix infinite loop on terminating backslash (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18004 )

Change subject: cli: Fix infinite loop on terminating backslash
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> I'm curious why this only affects remote consoles? Is this case handled elsewhere for the local one?
Not really sure, other than it only affects remote consoles because that's how the buggy logic was originally coded:

if (ast_opt_remote) {
   // buggy logic somewhere here
} else {
   // no buggy logic here
}

The best I can offer is that with foreground console it's calling the vector completion directly whereas with remote console tab complete has to go through a connection socket and so that interaction causes different behavior.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18004
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9810ac59304fec162da701653c9c834f0ec8f670
Gerrit-Change-Number: 18004
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 01:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/9cfa49cc/attachment.html>