[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[Kevin Harwell]

Attention is currently required from: N A, Sarah Autumn.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS4: 
> it requires separate modifications to /etc/dahdi/system.conf and /etc/asterisk/chan_dahdi.conf (not to mention an upcoming patch to the DAHDI kernel driver),

Admittedly I know very little about DAHDI, but I +1'd this as the code is simply enough and looked good to me. However, given the above it might be this code will need to wait to be merged until the other dependent patches have been merged into their respective repo's.

Or perhaps version checks could be put in place? At the very least maybe a mentioning of version dependencies somewhere? Maybe in the CHANGES section and/or the commit log.

Unless of course you're thinking the DAHDI changes may be not go in for a very long time, if at all and ppl will just manually apply patches themselves. Then I'm not sure. Maybe a mention/link to the other issues?

Maybe someone else has some other ideas...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 5
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Wed, 23 Feb 2022 22:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/b83d84f2/attachment.html>