[Asterisk-code-review] res_geolocation: Initial commit (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: Michael Bradeen, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18068 )

Change subject: res_geolocation:  Initial commit
......................................................................


Patch Set 9:

(6 comments)

File include/asterisk/res_geolocation.h:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/0bf124a9_ab922134 
PS8, Line 88: ot
> ot->or
Done


https://gerrit.asterisk.org/c/asterisk/+/18068/comment/5593fd4b_0eaceae9 
PS8, Line 141: struct ast_variable *varlist
> Apologies meant to mention this before, but I believe varlist can be made const here.
Done


File res/res_geolocation/geoloc_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/667bec3d_52c07a62 
PS8, Line 56: 	if (!profile) {
            : 		ast_datastore_free(ds);
            : 		ast_log(LOG_ERROR, "A profile with the name '%s' was not found", profile_name);
            : 	}
> This off nominal path should return NULL
Done


https://gerrit.asterisk.org/c/asterisk/+/18068/comment/d7f5a5f5_801b9b39 
PS8, Line 63: 	if (!eprofile) {
            : 		ast_datastore_free(ds);
            : 		ast_log(LOG_ERROR, "An effective profile with the name '%s' couldn't be allocated", profile_name);
            : 	}
> This off nominal path should return NULL
Done


File res/res_geolocation/geoloc_civicaddr.c:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/f223b643_28140907 
PS8, Line 111: 	struct ast_variable *var = (struct ast_variable *) varlist;
> You should just be able to make "var" const here and not have to cast.
Done


File res/res_geolocation/geoloc_private.h:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/b9bf7225_9b01edbe 
PS8, Line 136: struct ast_sorcery *geoloc_get_sorcery(void);
> Add a comment here that this returns the object with an added ref that the caller is responsible for […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18068
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb6e3640f31a676da42d8c144ebbb31ad795d849
Gerrit-Change-Number: 18068
Gerrit-PatchSet: 9
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 21:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/14008133/attachment-0001.html>