[Asterisk-code-review] ami: Allow events to be globally disabled. (asterisk[16])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18029 )

Change subject: ami: Allow events to be globally disabled.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/manager.c:

https://gerrit.asterisk.org/c/asterisk/+/18029/comment/e1564b5c_86470e07 
PS1, Line 7242: 		if (strstr(manager_disabledevents, event)) {
Doing it this way has the following problem:

Any shorter string may be found in a longer one. For example if disabledevents=ContactListComplete then the event ContactList will also match as "disabled"

Check out the "ast_in_delimited_string" function in strings.h. It might do what you want. If it doesn't then you'll need to loop over each item yourself.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18029
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id42b9a3722a1f460d745cad1ebc47c537fd4f205
Gerrit-Change-Number: 18029
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 21:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/3b376a63/attachment.html>