[Asterisk-code-review] core: Config and XML tweaks needed for geolocation (asterisk[development/16/geolocation])

[George Joseph]

Attention is currently required from: Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18067 )

Change subject: core: Config and XML tweaks needed for geolocation
......................................................................


Patch Set 5:

(4 comments)

File include/asterisk/xml.h:

https://gerrit.asterisk.org/c/asterisk/+/18067/comment/bbac842e_e1724f0b 
PS5, Line 205: anm
> Looks like this got missed s/anm/an
Done


File main/config.c:

https://gerrit.asterisk.org/c/asterisk/+/18067/comment/6611861b_5f2aa8ee 
PS5, Line 706: 		local_str = ast_str_create(AST_MAX_USER_FIELD);
> Need to check for NULL here on local_str just in case
Done


File tests/test_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18067/comment/fa88bf55_ce309c06 
PS5, Line 1900: 	struct ast_variable *var;
> I think this should be a const. See why below.
Done


https://gerrit.asterisk.org/c/asterisk/+/18067/comment/c20bcc15_8f50caae 
PS5, Line 1936: 	var = (struct ast_variable *)ast_variable_find_variable_in_list(list, "bbb");
              : 	ast_test_validate(test, var != NULL);
              : 	ast_variable_list_replace_variable(&list, var, ast_variable_new("eee", "555", ""));
> Personally I think the cast should be done on ast_variable_list_replace_variable, so it's obvious wh […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18067
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I330a5f63dc0c218e0d8dfc0745948d2812141ccb
Gerrit-Change-Number: 18067
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 16:44:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/617237a3/attachment-0001.html>