[Asterisk-code-review] chan_sip.c Session timers get removed on UPDATE (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17787 )

Change subject: chan_sip.c Session timers get removed on UPDATE
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17787/comment/56e7ec12_383a3f13 
PS2, Line 9: If Asterisk receives a SIP REFER with Session-Timers UAC, maintain Session-Timers when sending UPDATE"
This line is too long, please wrap it


File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/17787/comment/7b5c60df_f0c88c1f 
PS2, Line 12504: 	   This should only be added in the INVITE transactions, not MESSAGE or REFER or other
This comment no longer appears to be accurate.


File doc/CHANGES-staging/chan_sip_session-timer_on_update.txt:

https://gerrit.asterisk.org/c/asterisk/+/17787/comment/3190c38f_c84c9eb5 
PS2, Line 4: fix that if asterisk recive an SIP refer with Session-Timers UAC that asteriks maintain Session-Timers when sending UPDATE
Fix if Asterisk receives a SIP REFER with Session-Timers UAC that Asterisk maintains Session-Timers when sending UPDATE request



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17787
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8e9a21c13bf757fa34d778f49ba3cf859b29ae5c
Gerrit-Change-Number: 17787
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Wed, 23 Feb 2022 13:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220223/2c952e99/attachment.html>