[Asterisk-code-review] res_geolocation: Initial commit (asterisk[development/16/geolocation])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18068 )

Change subject: res_geolocation:  Initial commit
......................................................................


Patch Set 8: Code-Review-1

(5 comments)

File include/asterisk/res_geolocation.h:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/be6301a3_a873906f 
PS8, Line 141: struct ast_variable *varlist
Apologies meant to mention this before, but I believe varlist can be made const here.


File res/res_geolocation/geoloc_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/99e4712c_e9c9d0d2 
PS8, Line 56: 	if (!profile) {
            : 		ast_datastore_free(ds);
            : 		ast_log(LOG_ERROR, "A profile with the name '%s' was not found", profile_name);
            : 	}
This off nominal path should return NULL


https://gerrit.asterisk.org/c/asterisk/+/18068/comment/54dfc76c_e21471c0 
PS8, Line 63: 	if (!eprofile) {
            : 		ast_datastore_free(ds);
            : 		ast_log(LOG_ERROR, "An effective profile with the name '%s' couldn't be allocated", profile_name);
            : 	}
This off nominal path should return NULL


File res/res_geolocation/geoloc_civicaddr.c:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/edf7073b_b30c6271 
PS8, Line 111: 	struct ast_variable *var = (struct ast_variable *) varlist;
You should just be able to make "var" const here and not have to cast.


File res/res_geolocation/geoloc_private.h:

https://gerrit.asterisk.org/c/asterisk/+/18068/comment/bff5bce4_3177f209 
PS8, Line 136: struct ast_sorcery *geoloc_get_sorcery(void);
Add a comment here that this returns the object with an added ref that the caller is responsible for removing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18068
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb6e3640f31a676da42d8c144ebbb31ad795d849
Gerrit-Change-Number: 18068
Gerrit-PatchSet: 8
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 22:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/8dbbfd0c/attachment-0001.html>