[Asterisk-code-review] Makefile: Allow XML documentation to exist outside source files (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Tue Feb 22 15:11:49 CST 2022


Attention is currently required from: Michael Bradeen, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18014 )

Change subject: Makefile: Allow XML documentation to exist outside source files
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

File build_tools/get_sourceable_makeopts:

https://gerrit.asterisk.org/c/asterisk/+/18014/comment/35067cb5_c055e9e5 
PS4, Line 35: outp[ut
Pointed this out on the other review but meant to put it on this one (one with comments already on it) ...

looks like a stray  "[" in output, but this is only in a comment so meh. I'd say change it if someone finds something else otherwise no biggie.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I486c16c0b5a44d7a8870008e10c941fb19b71ade
Gerrit-Change-Number: 18014
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 21:11:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/b011ed61/attachment.html>


More information about the asterisk-code-review mailing list