[Asterisk-code-review] unsolicited/notify_after_register: properly handle test scenario (testsuite[16])

Michael Bradeen asteriskteam at digium.com
Tue Feb 22 13:38:24 CST 2022


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/testsuite/+/18070

to look at the new patch set (#2).

Change subject: unsolicited/notify_after_register: properly handle test scenario
......................................................................

unsolicited/notify_after_register: properly handle test scenario

There were two issues with the existing tests, affecting both the
standard and realtime versions of the test.

First, the xml contained a syntax error which caused an error on
current versions of sipp

Second, the scenario itself can not be handled by one sipp instance
as the NOTIFY will not match the call-ID of the REGISTER.

This is handled by splitting the test into two scenarios, one that
Registers with a contact port of 5062 then quits and a second that
waits for a NOTIFY on port 5062 then sends a 200 OK.

The REGISTER scenario waits 500ms for the NOTIFY scenario to start.

If both scenarios succeed, the test passes.

Change-Id: I23c7fbea995d99211552321f2d4c7e02806792e4
---
D tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register/sipp/notify_after_register.xml
A tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register/sipp/receive_notify.xml
A tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register/sipp/register_and_quit_two.xml
M tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register/test-config.yaml
D tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register_realtime/sipp/notify_after_register.xml
A tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register_realtime/sipp/receive_notify.xml
A tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register_realtime/sipp/register_and_quit_two.xml
M tests/channels/pjsip/subscriptions/mwi/unsolicited/notify_after_register_realtime/test-config.yaml
8 files changed, 106 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/70/18070/2
-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I23c7fbea995d99211552321f2d4c7e02806792e4
Gerrit-Change-Number: 18070
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/bd47f972/attachment.html>


More information about the asterisk-code-review mailing list