[Asterisk-code-review] logger: workaround woefully small BUFSIZ in MUSL (asterisk[master])

[Philip Prindeville]

Attention is currently required from: Joshua Colp.
Philip Prindeville has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18069 )

Change subject: logger: workaround woefully small BUFSIZ in MUSL
......................................................................


Patch Set 3:

(3 comments)

Patchset:

PS3: 
Addressed Joshua's comments.


File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/18069/comment/cadac3de_8eebfefd 
PS2, Line 99: 
> Add a comment explaining why we don't use BUFSIZ
Ack


https://gerrit.asterisk.org/c/asterisk/+/18069/comment/be7449ff_af9dea44 
PS2, Line 101: static const unsigned logger_logmsg_size = BUFSIZ;
> Why does this use a static const unsigned instead of just a #define?
I tend to do that so it's visible in a debugger or via objdump...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18069
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaa49fbbab029c64ae3d95e4b18270e0442cce170
Gerrit-Change-Number: 18069
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 17:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/d1bd4385/attachment.html>