[Asterisk-code-review] build: Refactor the earlier "basebranch" commit (asterisk[16])

[Kevin Harwell]

Attention is currently required from: N A, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18017 )

Change subject: build: Refactor the earlier "basebranch" commit
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

File build_tools/make_version:

https://gerrit.asterisk.org/c/asterisk/+/18017/comment/072ab764_e7ffe373 
PS4, Line 103:         MAINLINE_BRANCH=$(${GIT} config -f .gitreview --get gerrit.basebranch)
> > Since basebranch is no longer used can it be removed from the .gitreview file too? […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18017/comment/cb14eafb_c56a2a55 
PS4, Line 114:             # If we didn't find it, see if this is a well-known development branch.
             :             # development/<mainline_branch>/<branchname> or
             :             # devel/<mainline_branch>/<branchname>
             :             if [ "x${MAINLINE_BRANCH}" = "x" ] ; then
             :                 MAINLINE_BRANCH=$(echo "${BRANCH}" | ${SED} -n -r -e "s at devel(opment)?/([0-9]+)/.+@\2 at p")
             :             fi
> > Is this a usual convention? I feel like this case can be removed. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18017
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1cdeeaa0944bba3f2e01d7a2039559d0c266f8c9
Gerrit-Change-Number: 18017
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 16:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/3b4f8105/attachment.html>