[Asterisk-code-review] logger: workaround woefully small BUFSIZ in MUSL (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Feb 22 04:02:14 CST 2022


Attention is currently required from: Philip Prindeville.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18069 )

Change subject: logger: workaround woefully small BUFSIZ in MUSL
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/18069/comment/c6e11a50_2d420f4f 
PS2, Line 99: 
Add a comment explaining why we don't use BUFSIZ


https://gerrit.asterisk.org/c/asterisk/+/18069/comment/a03fe750_e78ebaed 
PS2, Line 101: static const unsigned logger_logmsg_size = BUFSIZ;
Why does this use a static const unsigned instead of just a #define?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18069
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaa49fbbab029c64ae3d95e4b18270e0442cce170
Gerrit-Change-Number: 18069
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 10:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/2c3fbd4e/attachment-0001.html>


More information about the asterisk-code-review mailing list