[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

Mark Murawski asteriskteam at digium.com
Mon Feb 21 20:54:15 CST 2022


Attention is currently required from: Sean Bright, N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 7:

(2 comments)

Patchset:

PS7: 
> You're probably aware of this, but FYI: […]
So weird that my local compiler doesn't catch some stuff like this.  As per Sean, I switched the list to a single.


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/255c1a66_3ae2925b 
PS7, Line 168: 				For more information, see the dialplan function GROUP_VAR().
> I don't see the documentation for the GROUP_VAR function itself anywhere - kind of the most importan […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 7
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 02:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/4a9515c4/attachment.html>


More information about the asterisk-code-review mailing list