[Asterisk-code-review] core: Config and XML tweaks needed for geolocation (asterisk[development/16/geolocation])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18067 )

Change subject: core: Config and XML tweaks needed for geolocation
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

File include/asterisk/config.h:

https://gerrit.asterisk.org/c/asterisk/+/18067/comment/e1f4117e_7e76a9d9 
PS3, Line 1005: struct ast_variable *head
I think this can be made "const" since "head" is (and should) not being modified.


https://gerrit.asterisk.org/c/asterisk/+/18067/comment/7ed32b65_3ed8c11b 
PS3, Line 1006: struct ast_str *str
I worry about the potential for a caller trying to use "str" after it's been invalidated. Why not just pass it in as a pointer to a pointer?

In doing so you can still check for, and create if NULL. Also, it makes it so there is no chance of a caller using an invalid pointer after this call (well they'd still have to check for NULL).


File include/asterisk/xml.h:

https://gerrit.asterisk.org/c/asterisk/+/18067/comment/31a8b5d6_71a58311 
PS3, Line 205:  * \brief Set or reset anm element's name.
s/anm/an



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18067
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I330a5f63dc0c218e0d8dfc0745948d2812141ccb
Gerrit-Change-Number: 18067
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 22:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/e52519ae/attachment.html>