[Asterisk-code-review] Makefile: Allow XML documentation to exist outside source files (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Michael Bradeen, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18014 )

Change subject: Makefile: Allow XML documentation to exist outside source files
......................................................................


Patch Set 3: Code-Review-1

(8 comments)

File build_tools/get_sourceable_makeopts:

https://gerrit.asterisk.org/c/asterisk/+/18014/comment/e3f189a9_896700b7 
PS3, Line 11: 		
redness


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/2b8da3d6_2540ec02 
PS3, Line 15: 		
redness


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/65dde51f_5301bee9 
PS3, Line 18: 		
redness


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/09ab7e6f_e00185e5 
PS3, Line 20: 		constructs.  It should be runnable by any shell. 
More whitespace at eol.


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/e739c3ac_16bd1cfd 
PS3, Line 36: # We don't WANT the variables evaluated. 
More whitespace.


File build_tools/make_xml_documentation:

https://gerrit.asterisk.org/c/asterisk/+/18014/comment/b510eb2a_fc8b66ff 
PS3, Line 26: 	
redness


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/edc0de2a_2ffca009 
PS3, Line 36: 	                  <output-file> and <core-output-file>. 
extra space at eol.


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/c97a6c21_21b23da7 
PS3, Line 40: 	
redness



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I486c16c0b5a44d7a8870008e10c941fb19b71ade
Gerrit-Change-Number: 18014
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 22:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/8ee86642/attachment.html>