[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright, N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 5:

(16 comments)

Patchset:

PS2: 
> apps/app_dial.c should be removed from the review altogether as nothing was changed there.
Done


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b9fb7590_4e0b26fd 
PS2, Line 29: #include "regex.h"
> Assuming this is supposed to be the system-supplied regex.h it should be in brackets: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d8cab4d6_94daf943 
PS2, Line 166: 			At a minimum, either group or category must be provided.
> I think this needs to be surrounded with <para> tags, as there are 5 of these warnings: Element desc […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/981caa63_5a6207f3 
PS2, Line 182: 			At a minimum, either group or category must be provided.
> Same here, needs para tags.
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/751ef785_8d0f0b3e 
PS2, Line 194: 			This will return a list of channel groups that are in use.
> Ditto
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/83ae6c29_8f6a7d5c 
PS2, Line 206: 			This will return a list the channels that are within each group.
> Ditto
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/c3454c68_be9a1fbb 
PS2, Line 218: 			This will return a list of groups and the variables assigned in each group.
> Ditto
Done


File include/asterisk/channel.h:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/bd685e91_b4746b90 
PS2, Line 129: #include "regex.h"
> Assuming this is supposed to be the system-supplied regex.h it should be in brackets: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b2bf123f_9e1711b8 
PS2, Line 3163:  * \since 11
> This should be: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/1bd7c62f_3842a86e 
PS2, Line 3177:  * \since 11
> This should be: […]
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/96695467_bbd8d94a 
PS2, Line 1: /*
> The leading whitespace of most of the lines you added looks wrong to me. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/d5f43289_3fe4588f 
PS2, Line 136: AST_DLLIST_HEAD_NOLOCK(group_list, group_list_entry);  /*!< All GROUP assignments */
> Why does this need to be doubly-linked list?
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/953f354e_41c879cd 
PS2, Line 148: AST_RWDLLIST_HEAD_STATIC(group_stores_list, group_data_store);
> Why does this need to be doubly-linked list?
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/7201508f_dc830fa1 
PS4, Line 2593:                 manager_event(EVENT_FLAG_DIALPLAN, "GroupDestroy",
> I don't see events like this documented anywhere. […]
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/2753e1b8_4a51ced8 
PS2, Line 1867: #include "asterisk/dlinkedlists.h"
> Move this to the top of the file with the other includes.
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/c9695b95_c03f4246 
PS2, Line 1876: 	AST_DLLIST_ENTRY(group_list_entry) entries;    /*!< Next group */
> Why does this need to be doubly-linked list?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 17:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/10dd00a5/attachment-0001.html>