[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[Mark Murawski]

Attention is currently required from: N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 5:

(5 comments)

File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/efca05ad_470a6ddc 
PS4, Line 622: //	const char *group    = astman_get_header(m, "Group");	 // todo: filtering
> If these variables aren't needed, get rid of them
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/5426bbe9_46ac57d4 
PS4, Line 660: //	const char *group = astman_get_header(m, "Group");	 // todo: filtering
> Same thing here
Done


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b3393dee_39d32526 
PS4, Line 131: 	struct group_data_store *group_store;          /*!< The group_data_store we live on */ 
> Trailing whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/79fb066b_4ace68bd 
PS4, Line 2703:                 strncpy(gi->category, new_category, MAX_CATEGORY_LEN);
> You need to address this compiler warning: […]
Done


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/395db477_51d0c269 
PS4, Line 1906: 	struct group_data_store *group_store;          /*!< The group_data_store we live on. (Type: struct tie_data_store *) */ 
> Trailing whitespace […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 21 Feb 2022 17:07:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/58b91bf9/attachment.html>