[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Mark Murawski.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 4:

(7 comments)

Patchset:

PS4: 
This patch triggers whitespace warnings when applied - I've noted inline where these issues exist:

Gerrit Patchset: https://gerrit.asterisk.org/changes/asterisk~17655/revisions/4/patch?download
Downloading and applying Gerrit patch 17655
17655.diff:1130: trailing whitespace.
        struct group_data_store *group_store;          /*!< The group_data_store we live on */
17655.diff:1660: trailing whitespace.
        struct group_data_store *group_store;          /*!< The group_data_store we live on. (Type: struct tie_data_store *) */
warning: 2 lines add whitespace errors.

A few additional comments below, in addition to those still pending:


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/0aa4e7c5_c18b3e6d 
PS4, Line 622: //	const char *group    = astman_get_header(m, "Group");	 // todo: filtering
If these variables aren't needed, get rid of them


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/4b9f9d55_369607c2 
PS4, Line 660: //	const char *group = astman_get_header(m, "Group");	 // todo: filtering
Same thing here


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/724ecacd_83952e9f 
PS4, Line 131: 	struct group_data_store *group_store;          /*!< The group_data_store we live on */ 
Trailing whitespace


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/b2c61252_72da7216 
PS4, Line 2593:                 manager_event(EVENT_FLAG_DIALPLAN, "GroupDestroy",
I don't see events like this documented anywhere.
Every AMI event should have documentation.


https://gerrit.asterisk.org/c/asterisk/+/17655/comment/40f83a8a_3c042c49 
PS4, Line 2703:                 strncpy(gi->category, new_category, MAX_CATEGORY_LEN);
You need to address this compiler warning:

app.c:2707:17: warning: ‘strncpy’ specified bound 80 equals destination size [-Wstringop-truncation]
                 strncpy(gmi->category, new_category, MAX_CATEGORY_LEN);


File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/fd765871_761762ba 
PS4, Line 1906: 	struct group_data_store *group_store;          /*!< The group_data_store we live on. (Type: struct tie_data_store *) */ 
Trailing whitespace
Also, get rid of the (Type: struct tie_data_store)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sat, 19 Feb 2022 13:40:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220219/2a32335e/attachment.html>