[Asterisk-code-review] app_voicemail: Throw warning if asking for nonexistent mailbox. (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Feb 16 09:10:41 CST 2022


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18016 )

Change subject: app_voicemail: Throw warning if asking for nonexistent mailbox.
......................................................................


Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18016/comment/4f0a53a6_a94147ad 
PS1, Line 7: Throw 
'Emit' or 'Log' instead of 'Throw.'


Patchset:

PS1: 
Don't mix functional and non-functional changes in a single review. If you really want to clean up braces you can do it in a separate formatting-only review.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18016
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4093b88cd661a2cabc5d685777d4e2f0ebd20a4
Gerrit-Change-Number: 18016
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 15:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/98ad1d47/attachment.html>


More information about the asterisk-code-review mailing list