[Asterisk-code-review] res_stir_shaken: refactor utility function (asterisk[16])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17961 )

Change subject: res_stir_shaken: refactor utility function
......................................................................


Patch Set 3:

(3 comments)

File include/asterisk/file.h:

https://gerrit.asterisk.org/c/asterisk/+/17961/comment/5ba1883a_eb4ce1e1 
PS2, Line 154:  * \param path The directory path to create the file in
> Add a note that the directory will be created if it does not exist
Done


https://gerrit.asterisk.org/c/asterisk/+/17961/comment/1feaac4a_c9584e52 
PS2, Line 156:  * \param template_name Template name for created temp file
> I would use language closer to what the mkstemp manpage uses for this. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/17961/comment/825af3b4_20532e5f 
PS2, Line 157:  *
> Add a \note that filename will need to be freed with ast_free(...) if this function succeeds.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17961
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ife478708c8f2b127239cb73c1755ef18c0bf431b
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 11:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220216/3f13c2fa/attachment.html>