[Asterisk-code-review] geolocation: Add sample config file (asterisk[development/16/geolocation])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18015 )

Change subject: geolocation:  Add sample config file
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
More of question, but -1 for notice.


File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18015/comment/092348b0_6c43acf0 
PS1, Line 122: ;-- location ---------------------------------------
             : 
             : The actual location information to send.  The format depends on the
             : "format" parameter set above.  For readability, multiple "location"
             : parameters can be specified and they will be concatenated into one
             : specification.
Looks like a particular location can be used for multiple profiles. I wonder if it would make more sense to make them their own typed section in sorcery. Especially since each location is also associated with a number of name/value parameters depending on the type of location.

Thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18015
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb809ed5f843c64528f00a3f08493f24cf4f0ee5
Gerrit-Change-Number: 18015
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 23:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220215/7533eb34/attachment-0001.html>