[Asterisk-code-review] Makefile: Allow XML documentation to exist outside source files (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Sean Bright.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18014 )

Change subject: Makefile: Allow XML documentation to exist outside source files
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
> My code review was removed. Reiterating so it doesn’t get missed:
> 
> It would go a long way in terms of legibility if we moved the logic that is embedded in the Makefile into a separate script.
> 
> 

Good point.  Will do.


PS1: 
> When I configure / menuselect / make on ubuntu 20.04, I get stuck here:
> make
> make[1]: Entering directory '/usr/src/asterisk/asterisk-16'
> /bin/sh: 1: channels: not found
> 
> If I configure / menuselect in the main branch, then switch to this change then run make, it builds.
> 
> It seems .lastclean is not being created.

Hmmm.  I didn't touch that bit at all.  I'll test more.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I486c16c0b5a44d7a8870008e10c941fb19b71ade
Gerrit-Change-Number: 18014
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 12:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220215/53ef6074/attachment-0001.html>