[Asterisk-code-review] res_stir_shaken: refactor utility functions (asterisk[16])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17961 )

Change subject: res_stir_shaken: refactor utility functions
......................................................................


Patch Set 2:

(1 comment)

File res/res_stir_shaken/curl.c:

https://gerrit.asterisk.org/c/asterisk/+/17961/comment/47918182_2e44b4a7 
PS2, Line 174: 	fd = ast_create_temp_file(path, &tmp_filename, template_name);
> Why wouldn't ast_file_mkftemp(...) work here? […]
I was trying to preserve the way it was being done, but I guess it doesn't need the fd for anything but the FILE*.

What about making that function a wrapper around ast_file_mktemp that does the ast_asprintf. That way callers don't need to do that part manually.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17961
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ife478708c8f2b127239cb73c1755ef18c0bf431b
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 17:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220214/4be71218/attachment-0001.html>