[Asterisk-code-review] app_queue: Add QueueWithdrawCaller AMI	action (asterisk[16])
    Kfir Itzhak 
    asteriskteam at digium.com
       
    Mon Feb 14 08:26:56 CST 2022
    
    
  
Attention is currently required from: Joshua Colp.
Kfir Itzhak has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18008 )
Change subject: app_queue: Add QueueWithdrawCaller AMI action
......................................................................
Patch Set 6:
(4 comments)
Patchset:
PS4: 
> About CHANGES
Done, thank you!
Patchset:
PS6: 
All resolved
File apps/app_queue.c:
https://gerrit.asterisk.org/c/asterisk/+/18008/comment/b0125d30_9692530f 
PS4, Line 7689: 					qe->withdraw_info = ast_strdup(withdraw_info);
> Add a comment that it is impossible for withdraw_info to already be set as only a single withdraw re […]
Ack
https://gerrit.asterisk.org/c/asterisk/+/18008/comment/14cfefb4_b41aa9e9 
PS4, Line 8797: 	if (qe.withdraw_info != NULL) {
> We just use if (qe. […]
Ack
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18008
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic15aa238e23b2884abdcaadff2fda7679e29b7ec
Gerrit-Change-Number: 18008
Gerrit-PatchSet: 6
Gerrit-Owner: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 14:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220214/a0a89a15/attachment.html>
    
    
More information about the asterisk-code-review
mailing list