[Asterisk-code-review] file.c: ast_fileexists filename is empty or NULL (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Mark Petersen.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18011 )

Change subject: file.c: ast_fileexists filename is empty or NULL
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Under what case did this actually happen? Is this change actually still applicable?
hmm it used to be a problem if you did a Playback(${EMPTY_VAR})
but I have just teste and that is now handled in Playback
so no, unless someone else think is should be added


Playback("SIP/hpbx-00000002", "") in new stack
WARNING[353047][C-00000002]: app_playback.c:464 playback_exec: Playback requires an argument (filename)
  == Spawn extension (hpbx, 201, 3) exited non-zero on 'SIP/hpbx-00000002'



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18011
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic1617fec118e8497c3a0ff8675a572f75cff34c0
Gerrit-Change-Number: 18011
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Mon, 14 Feb 2022 12:52:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220214/0167ce3a/attachment.html>